[Scripting Question] Custom Script keeps trying to find "length"

[Mutant Yoshi]

So Rot8er_ConeX helped me create a script that forces you to encounter a specific Pokemon with in an event. It works well except for one problem. Once the battle ends, the game crashes with this error:

Spoiler:

Exception: RuntimeError

Message: Script error within event 33, map 92 (Test Map):

Exception: NoMethodError

Message: Section129:70undefined method `length' for nil:NilClass

***Full script:

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
pbSpecificWildBattle(poke,0)


Interpreter:243:in `pbExecuteScript'

Pokemon_ShadowPokemon:67:in `call'

Event:54:in `trigger'

Event:49:in `each'

Event:49:in `trigger'

PField_Field:982:in `pbSpecificWildBattle'

PField_Field:958:in `pbBattleAnimation'

PField_Field:958:in `pbSpecificWildBattle'

(eval):5:in `pbExecuteScript'

Interpreter:1606:in `eval'



Interpreter:276:in `pbExecuteScript'

Interpreter:1606:in `command_355'

Interpreter:494:in `execute_command'

Interpreter:193:in `update'

Interpreter:106:in `loop'

Interpreter:198:in `update'

Scene_Map:103:in `follow_update'

Scene_Map:101:in `loop'

Scene_Map:114:in `follow_update'

FollowingPokemon:1550:in `update'

For some strange reason, it's looking for "length" in the code, but the code itself never even calls for "length" in the first place, so I don't understand why it's even looking for it. Here's the code for the method:

def pbSpecificWildBattle(pokemon,level,variable=nil,canescape=true,canlose=false)
  if (Input.press?(Input::CTRL) && $DEBUG) || $Trainer.pokemonCount==0
    if $Trainer.pokemonCount>0
      Kernel.pbMessage(_INTL("SKIPPING BATTLE..."))
    end
    pbSet(variable,1)
    $PokemonGlobal.nextBattleBGM=nil
    $PokemonGlobal.nextBattleME=nil
    $PokemonGlobal.nextBattleBack=nil
    return true
  end
  handled=[nil]
  Events.onWildBattleOverride.trigger(nil,pokemon.species,level,handled)
  if handled[0]!=nil
    return handled[0]
  end
  currentlevels=[]
  for i in $Trainer.party
    currentlevels.push(i.level)
  end
  scene=pbNewBattleScene
  battle=PokeBattle_Battle.new(scene,$Trainer.party,[pokemon],$Trainer,nil)
  battle.internalbattle=true
  battle.cantescape=!canescape
  pbPrepareBattle(battle)
  decision=0
  pbBattleAnimation(pbGetWildBattleBGM(pokemon.species)) { 
     pbSceneStandby {
        decision=battle.pbStartBattle(canlose)
     }
     for i in $Trainer.party; (i.makeUnmega rescue nil); end
     if $PokemonGlobal.partner
       pbHealAll
       for i in $PokemonGlobal.partner[3]
         i.heal
         i.makeUnmega rescue nil
       end
     end
     if decision==2 || decision==5 # if loss or draw
       if canlose
         for i in $Trainer.party; i.heal; end
         for i in 0...10
           Graphics.update
         end
#       else
#         $game_system.bgm_unpause
#         $game_system.bgs_unpause
#         Kernel.pbStartOver
       end
     end
     Events.onEndBattle.trigger(nil,decision,canlose)
  }
  Input.update
  pbSet(variable,decision)
  Events.onWildBattleEnd.trigger(nil,species,level,decision)
  return (decision!=2)
end

And here's the code used in the event script:

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
pbSpecificWildBattle(poke,0)

What am I doing wrong? This is very frustrating as I have no idea why it's searching for "length".

 

[The Master]

Your report says all you need: "Section 129:70". It means that in the 129th script, starting from top to bottom, in the 70th line, there is a conflict with your code. What's in that script? Post a reply with code or spoiler tag, containing this section (e.g. PokeBattle_Scene), so i can help you.

 

[Mutant Yoshi]

Your report says all you need: "Section 129:70". It means that in the 129th script, starting from top to bottom, in the 70th line, there is a conflict with your code. What's in that script? Post a reply with code or spoiler tag, containing this section (e.g. PokeBattle_Scene), so i can help you.

I think I miscounted. When I counted the scripts, I came across this:

Spoiler:

def pbPushThisBoulder
    if $PokemonMap.strengthUsed
      pbPushThisEvent
    end
    return true
  end

And this doesn't seem right.
This is in PField_Field by the way.

 

[The Master]

Yes, you probably miscounted. You must also take into account the "blank" script and those that have no name.
E.g., in the newest version of Essentials (16.2), the 129th script section is "Pokemon_Sprites".

 

[Mutant Yoshi]

Yes, you probably miscounted. You must also take into account the "blank" script and those that have no name.
E.g., in the newest version of Essentials (16.2), the 129th script section is "Pokemon_Sprites".

OH! Now I know what you mean! Sorry about that.
The 129th section in my file is Pokemon_ShadowPokemon. When going through line 70, I find this:

Events.onEndBattle+=proc {|sender,e|
   decision=e[0]
   canlose=e[1]
   for i in 0...$PokemonTemp.heartgauges.[COLOR=Red][B]length[/B][/COLOR]
     pokemon=$Trainer.party[i]
     if pokemon && ($PokemonTemp.heartgauges[i] &&
        $PokemonTemp.heartgauges[i]!=0 && pokemon.heartgauge==0)
       pbReadyToPurify(pokemon)
     end
   end
}

 

[The Master]

OH! Now I know what you mean! Sorry about that.
The 129th section in my file is Pokemon_ShadowPokemon. When going through line 70, I find this:

Events.onEndBattle+=proc {|sender,e|
   decision=e[0]
   canlose=e[1]
   for i in 0...$PokemonTemp.heartgauges.[COLOR=Red][B]length[/B][/COLOR]
     pokemon=$Trainer.party[i]
     if pokemon && ($PokemonTemp.heartgauges[i] &&
        $PokemonTemp.heartgauges[i]!=0 && pokemon.heartgauge==0)
       pbReadyToPurify(pokemon)
     end
   end
}

This is the correct code:

def pbSpecificWildBattle(pokemon,level,variable=nil,canescape=true,canlose=false)
  if (Input.press?(Input::CTRL) && $DEBUG) || $Trainer.pokemonCount==0
    if $Trainer.pokemonCount>0
      Kernel.pbMessage(_INTL("SKIPPING BATTLE..."))
    end
    pbSet(variable,1)
    $PokemonGlobal.nextBattleBGM=nil
    $PokemonGlobal.nextBattleME=nil
    $PokemonGlobal.nextBattleBack=nil
    return true
  end
  handled=[nil]
  species=pokemon.species
  Events.onWildBattleOverride.trigger(nil,species,level,handled)
  if handled[0]!=nil
    return handled[0]
  end
  currentlevels=[]
  for i in $Trainer.party
    currentlevels.push(i.level)
  end
  Events.onStartBattle.trigger(nil,pokemon)
  scene=pbNewBattleScene
  battle=PokeBattle_Battle.new(scene,$Trainer.party,[pokemon],$Trainer,nil)
  battle.internalbattle=true
  battle.cantescape=!canescape
  pbPrepareBattle(battle)
  decision=0
  pbBattleAnimation(pbGetWildBattleBGM(species)) { 
     pbSceneStandby {
        decision=battle.pbStartBattle(canlose)
     }
     for i in $Trainer.party; (i.makeUnmega rescue nil); end
     if $PokemonGlobal.partner
       pbHealAll
       for i in $PokemonGlobal.partner[3]
         i.heal
         i.makeUnmega rescue nil
       end
     end
     if decision==2 || decision==5 # if loss or draw
       if canlose
         for i in $Trainer.party; i.heal; end
         for i in 0...10
           Graphics.update
         end
#       else
#         $game_system.bgm_unpause
#         $game_system.bgs_unpause
#         Kernel.pbStartOver
       end
     end
     Events.onEndBattle.trigger(nil,decision,canlose)
  }
  Input.update
  pbSet(variable,decision)
  Events.onWildBattleEnd.trigger(nil,species,level,decision)
  return (decision!=2)
end

 

[Mutant Yoshi]

That worked! It's fixed now! Thank-you!

 

[Mutant Yoshi]

Oh, one more thing, actually. I'm trying to connect the script to events since when I tried it out before, fleeing, catching, or defeating the Pokemon didn't trigger the events like a normal fateful encounter would, but whenever I tried to connect them, fleeing always results in the event thinking you beat them.

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
result = pbSpecificWildBattle(poke,0)
pbSet(1, result == BR_WIN ? 0 : 1)

I have the Temp Pokemon Choice programmed to where it's 1 if you win, 3 if you flee, and 4 if you catch it, but fleeing seems to trigger 1.

 

[tustin2121]

I don't know how your pbSpecificWildBattle function works, but the Essentials default pbWildBattle function has the following at the end:

  return (decision!=2)

That will return a true from the method if you've not lost (which includes fleeing and catching), and false if you have lost. If this is at the end of pbSpecificWildBattle, then you're losing information there in a similar fashion.

Further, that snippet of code you have there is deliberately setting global variable 1 to either 0 or 1, 0 if you win, 1 if you didn't (assuming BR_WIN is defined as either true or 1).

Of course, pbWildBattle in Essentials has an optional parameter where you can pass a variable number, and it'll store the battle decision in that global variable itself. You should see if pbSpecificWildBattle has something similar and use that.

def pbWildBattle(species,level,variable=nil,canescape=true,canlose=false)

 

[Mutant Yoshi]

I don't know how your pbSpecificWildBattle function works, but the Essentials default pbWildBattle function has the following at the end:

  return (decision!=2)

That will return a true from the method if you've not lost (which includes fleeing and catching), and false if you have lost. If this is at the end of pbSpecificWildBattle, then you're losing information there in a similar fashion.

Further, that snippet of code you have there is deliberately setting global variable 1 to either 0 or 1, 0 if you win, 1 if you didn't (assuming BR_WIN is defined as either true or 1).

Of course, pbWildBattle in Essentials has an optional parameter where you can pass a variable number, and it'll store the battle decision in that global variable itself. You should see if pbSpecificWildBattle has something similar and use that.

def pbWildBattle(species,level,variable=nil,canescape=true,canlose=false)

It does, actually. However, I'm not exactly sure how to actually call each decision. I tried replacing BR_WIN with "result == @decision", but that just makes it to where it thinks every action is when you run from it in battle.

 

[The Master]

Oh, one more thing, actually. I'm trying to connect the script to events since when I tried it out before, fleeing, catching, or defeating the Pokemon didn't trigger the events like a normal fateful encounter would, but whenever I tried to connect them, fleeing always results in the event thinking you beat them.

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
result = pbSpecificWildBattle(poke,0)
pbSet(1, result == BR_WIN ? 0 : 1)

I have the Temp Pokemon Choice programmed to where it's 1 if you win, 3 if you flee, and 4 if you catch it, but fleeing seems to trigger 1.

It seems pretty clear why the result is always 1:

pbSet(1, result == BR_WIN ? 0 : 1)

With your code, the Global variable is set to 1, because the game checks if result is equal to BR_WIN; in that case the value is 1, while in the other case is 0.
Your code should to be like this:

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
pbSet(1,pbSpecificWildBattle(poke,0))

 

[Mutant Yoshi]

Your code should to be like this:

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
pbSet(1,pbSpecificWildBattle(poke,0))

Sadly, that didn't work either. Making the Krookodile faint or catching it just treated it as though I ran from it.

 

[The Master]

Make a test: before this line

pbSet(variable,decision)

Make a new one:

Kernel.pbMessage(_INTL("{1}",decision))

 

[Mutant Yoshi]

Make a test: before this line

pbSet(variable,decision)

Make a new one:

Kernel.pbMessage(_INTL("{1}",decision))

Running away has returned the message "3".
Making it faint has returned the message "1", but the defeated event didn't play.
Catching it has returned the massage "4", but it still remains on the map.

So now I know that it's calling the decisions properly, but it's not calling the events for whatever reason.

 

[The Master]

I'll make a test for you and then i'll post the solution.

Try to do this:

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
pbSpecificWildBattle(poke,0,1)

 

[Mutant Yoshi]

If it helps any, this is how the event is set up.

 

[The Master]

If it helps any, this is how the event is set up.

This is correct, but I've found a solution in my previous post.

 

[Mutant Yoshi]

Try to do this:

poke=pbGenerateWildPokemon(PBSpecies::KROOKODILE,35)
poke.makeDelta
poke.deltatype=getConst(PBTypes,:WATER)
poke.deltatype2=getConst(PBTypes,:POISON)
pbSpecificWildBattle(poke,0,1)

That seemed to fix it! Thank-you!