[Essentials v17.2] Gen 8 stuffs (Abilities, Items & Move)

[Softshade]

Shell Side Arm

In PokeBattle_MoveEffects, paste below any other function code (Set XXX to a new code)

Spoiler:

################################################################################
# Becomes physical if Atk does more than Sp. Atk. May poison target (Shell Side Arm)
################################################################################
class PokeBattle_Move_XXX < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    stagemul=[10,10,10,10,10,10,10,15,20,25,30,35,40]
    stagediv=[40,35,30,25,20,15,10,10,10,10,10,10,10]
    calcattackstage=attacker.stages[PBStats::ATTACK]+6
    calcattack=(attacker.attack*1.0*stagemul[calcattackstage]/stagediv[calcattackstage]).floor
    calcspatkstage=attacker.stages[PBStats::SPATK]+6
    calcspatk=(attacker.spatk*1.0*stagemul[calcspatkstage]/stagediv[calcspatkstage]).floor
    calcdefensestage=opponent.stages[PBStats::DEFENSE]+6
    calcdefense=(opponent.defense*1.0*stagemul[calcdefensestage]/stagediv[calcdefensestage]).floor
    calcspdefstage=opponent.stages[PBStats::SPDEF]+6
    calcspdef=(opponent.spdef*1.0*stagemul[calcspdefstage]/stagediv[calcspdefstage]).floor
    
    @category=(calcattack-calcdefense>calcspatk-calcspdef) ? 0 : 1
    @flags= (calcattack-calcdefense>calcspatk-calcspdef) ? @flags : @flags && (0x02 || 0x10 || 0x20) #Turns off contact if special move
 
    return super(attacker,opponent,hitnum,alltargets,showanimation) if pbIsDamaging?
  end
  
  def pbAdditionalEffect(attacker,opponent)
    return if opponent.damagestate.substitute
    if opponent.pbCanPoison?(attacker,false,self)
      opponent.pbPoison(attacker)
    end
  end
end

In your Moves.txt PBS file add the following, where YYY is a new number and XXX is the function code

Spoiler:

YYY,SHELLSIDEARM,Shell Side Arm,XXX,90,POISON,Physical,100,10,10,00,0,abef,"This move inflicts physical or special damage, whichever will be more effective. This may also poison the target."

 

[Softshade]

Galarian Slowbro
In your Pokemon Forms PBS file add

Spoiler:

#-------------------------------
[SLOWPOKE-1]
FormName=Galar Form
Type1=PSYCHIC
Abilities=GLUTTONY,OWNTEMPO
HiddenAbility=REGENERATOR
Moves=1,TACKLE,1,CURSE,3,GROWL,6,ACID,9,YAWN,12,CONFUSION,15,DISABLE,18,WATERPULSE,21,HEADBUTT,24,ZENHEADBUTT,27,AMNESIA,30,SURF,33,SLACKOFF,36,PSYCHIC,39,PSYCHUP,42,RAINDANCE,45,HEALPULSE
WildItemUncommon=
Evolutions=SLOWBRO,Item,GALARICACUFF
#-------------------------------
[SLOWBRO-1]
FormName=Galar Form
Type1=POISON
Type2=PSYCHIC
BaseStats=95,100,95,30,100,70
Weight=70.5
Height=1.6
Abilities=QUICKDRAW
HiddenAbility=REGENERATOR
Moves=1,SHELLSIDEARM,1,WITHDRAW,1,TACKLE,1,CURSE,1,GROWL,1,ACID,9,YAWN,12,CONFUSION,15,DISABLE,18,WATERPULSE,21,HEADBUTT,24,ZENHEADBUTT,27,AMNESIA,30,SURF,33,SLACKOFF,36,PSYCHIC,39,PSYCHUP,42,RAINDANCE,45,HEALPULSE
WildItemUncommon=

Make sure if you have Mega forms to change Mega Slowbro to form # 2, in your graphics and in your forms file.

Quick Draw Ability
In PokeBattle_Battle, where it defines pbPriority, add the lines for quickdraw everywhere you find it in this block

Spoiler:

def pbPriority(ignorequickclaw=false,log=false)
    return @priority if @usepriority # use stored priority if round isn't over yet
    @priority.clear
    speeds=[]
    priorities=[]
    quickclaw=[]; lagging=[]
    quickdraw=[]
    minpri=0; maxpri=0
    temp=[]
    # Calculate each Pokémon's speed
    for i in 0...4
      speeds[i]=@battlers[i].pbSpeed
      quickclaw[i]=false
      lagging[i]=false
      quickdraw[i]=false
      if !ignorequickclaw && @choices[i][0]==1 # Chose to use a move
        if !quickclaw[i] && !quickdraw[i] && @battlers[i].hasWorkingItem(:CUSTAPBERRY) &&
           !@battlers[i].pbOpposing1.hasWorkingAbility(:UNNERVE) &&
           !@battlers[i].pbOpposing2.hasWorkingAbility(:UNNERVE)
          if (@battlers[i].hasWorkingAbility(:GLUTTONY) && @battlers[i].hp<=(@battlers[i].totalhp/2).floor) ||
             @battlers[i].hp<=(@battlers[i].totalhp/4).floor
            pbCommonAnimation("UseItem",@battlers[i],nil)
            quickclaw[i]=true
            pbDisplayBrief(_INTL("{1}'s {2} let it move first!",
               @battlers[i].pbThis,PBItems.getName(@battlers[i].item)))
            @battlers[i].pbConsumeItem
          end
        end
        if !quickclaw[i] && @battlers[i].hasWorkingItem(:QUICKCLAW)
          if pbRandom(10)<2
            pbCommonAnimation("UseItem",@battlers[i],nil)
            quickclaw[i]=true
            pbDisplayBrief(_INTL("{1}'s {2} let it move first!",
               @battlers[i].pbThis,PBItems.getName(@battlers[i].item)))
          end
        end
        if !quickclaw[i] && !quickdraw[i] && @battlers[i].hasWorkingAbility(:QUICKDRAW)
          if pbRandom(10)<2
            
            quickdraw[i]=true
            pbDisplayBrief(_INTL("{1}'s Quick Draw let it move first!",
               @battlers[i].pbThis))
          end
        end
        if !quickclaw[i] && !quickdraw[i] &&
           (@battlers[i].hasWorkingAbility(:STALL) ||
           @battlers[i].hasWorkingItem(:LAGGINGTAIL) ||
           @battlers[i].hasWorkingItem(:FULLINCENSE))
          lagging[i]=true
        end
      end
    end
    # Calculate each Pokémon's priority bracket, and get the min/max priorities
    for i in 0...4
      # Assume that doing something other than using a move is priority 0
      pri=0
      if @choices[i][0]==1 # Chose to use a move
        pri=@choices[i][2].priority
        pri+=1 if @battlers[i].hasWorkingAbility(:PRANKSTER) &&
                  @choices[i][2].pbIsStatus?
        pri+=1 if @battlers[i].hasWorkingAbility(:GALEWINGS) &&
                  @battlers[i].hp==@battlers[i].totalhp && # CHANGED        
                  isConst?(@choices[i][2].type,PBTypes,:FLYING)
      end
      priorities[i]=pri
      if i==0
        minpri=pri
        maxpri=pri
      else
        minpri=pri if minpri>pri
        maxpri=pri if maxpri<pri
      end
    end
    # Find and order all moves with the same priority
    curpri=maxpri
    loop do
      temp.clear
      for j in 0...4
        temp.push(j) if priorities[j]==curpri
      end
      # Sort by speed
      if temp.length==1
        @priority[@priority.length]=@battlers[temp[0]]
      elsif temp.length>1
        n=temp.length
        for m in 0...temp.length-1
          for i in 1...temp.length
            # For each pair of battlers, rank the second compared to the first
            # -1 means rank higher, 0 means rank equal, 1 means rank lower
            cmp=0
            if quickclaw[temp[i]] || quickdraw[temp[i]]
              cmp=-1
              if quickclaw[temp[i-1]] || quickdraw[temp[i-1]]
                if speeds[temp[i]]==speeds[temp[i-1]]
                  cmp=0
                else
                  cmp=(speeds[temp[i]]>speeds[temp[i-1]]) ? -1 : 1
                end
              end

In your Abilities.txt PBS file add the line following where XXX is a new number.

Spoiler:

XXX,QUICKDRAW,Quick Draw,"Enables the Pokémon to move first occasionally."

Galarica Cuff Slowbro evolution item
In your items.txt PBS file add the Galarica Cuff and if you want, Galarica Twigs (Your desired bag pocket for the galarica twigs may differ from mine, I put it in a bag pocket I have called valuables)

Spoiler:

XXX,GALARICATWIG,Galarica Twig,Galarica Twigs,6,20,"A twig from a species of tree called Galarica that grows in certain areas around the Galar region. It's a material for an accessory for a certain Pokémon.",0,0,0,
YYY,GALARICACUFF,Galarica Cuff,Galarica Cuffs,6,3000,"A cuff made from woven-together Galarica Twigs. Giving it to Galarian Slowpoke makes the Pokémon very happy.",1,0,7,

Add the Galarica Cuff to the fling damage array in Pokebattle move effects. I have it at the same damage as an evolutionary stone, not sure if that has been determined properly from the games yet.

Add the image files to your Graphics/Icons Folder

Spoiler:

 

[Softshade]

Expanding Force
In PokeBattle_Battler under User=pbFindUser(choice,targets) add the following lines

Spoiler:

    user=pbFindUser(choice,targets)
    #Change to two targets for expanding force with psychic terrain
    if isConst?(thismove.id,PBMoves,:EXPANDINGFORCE) && @battle.field.effects[PBEffects::PsychicTerrain]>0 && !user.isAirborne? && @battle.doublebattle 
      targets = [pbOpposing1, pbOpposing2] if (!pbOpposing1.isFainted? && !pbOpposing2.isFainted?)
    end
    # Battle Arena only - assume failure

In the moves.txt PBS file add a new move number (YYY) with new function code (XXX)

Spoiler:

YYY,EXPANDINGFORCE,Expanding Force,XXX,80,PSYCHIC,Special,100,20,0,00,0,bef,"The user attacks the target with its psychic power. This move's power goes up and damages all opposing Pokémon on Psychic Terrain."

And finally in PokeBattle_Move_Effects add a new function code XXX

Spoiler:

################################################################################
# Gets powered up and can hit multiple targets if psychic terrain is up (Expanding Force)
################################################################################
class PokeBattle_Move_XXX < PokeBattle_Move
  def pbModifyDamage(damagemult,attacker,opponent)
    if @battle.field.effects[PBEffects::PsychicTerrain]>0 && !attacker.isAirborne?
      return (damagemult*2.0/1.3).round
    end
    return damagemult
  end
  
end

 

[Diegou18]

A short but useful thing: add Heal Bell's code to Soundproof Ability.

if !user.hasMoldBreaker && target.hasWorkingAbility(:SOUNDPROOF) &&
       thismove.isSoundBased? &&
       thismove.function!=0xE5 &&   # Perish Song handled elsewhere
       thismove.function!=0x151 &&  # Parting Shot handled elsewhere
       thismove.function!=0x19      # Heal Bell
      PBDebug.log("[Ability triggered] #{target.pbThis}'s Soundproof blocked #{user.pbThis(true)}'s #{thismove.name}")
      @battle.pbDisplay(_INTL("{1}'s {2} blocks {3}!",target.pbThis,
         PBAbilities.getName(target.ability),thismove.name))
      return false
    end

Generation VIII
Heal Bell now always affects the user, even if it has Soundproof. (Bulbapedia)

 

[Softshade]

Steel Roller
In your moves.txt PBS file add the following line, where YYY is a new move number and XXX is a new function code

Spoiler:

YYY,STEELROLLER,Steel Roller,XXX,130,STEEL,Physical,100,5,0,00,0,abef,"The user attacks while destroying the terrain. This move fails when the ground hasn't turned into a terrain."

In PokeBattle_MoveEffects add a new funciton code

Spoiler:

################################################################################
# Destroys the terrain (Steel Roller)
################################################################################
class PokeBattle_Move_XXX < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if @battle.field.effects[PBEffects::GrassyTerrain]==0 && @battle.field.effects[PBEffects::ElectricTerrain]==0 && 
       @battle.field.effects[PBEffects::PsychicTerrain]==0 && @battle.field.effects[PBEffects::MistyTerrain]==0
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    
    else 
      @battle.field.effects[PBEffects::GrassyTerrain]=0 
      @battle.field.effects[PBEffects::ElectricTerrain]=0  
      @battle.field.effects[PBEffects::PsychicTerrain]=0 
      @battle.field.effects[PBEffects::MistyTerrain]=0
      @battle.pbDisplay(_INTL("The terrain was removed."))
      return super(attacker,opponent,hitnum,alltargets,showanimation) if pbIsDamaging?
    end
  end  
end

 

[Softshade]

Rising Voltage
In moves.txt, add this line where YYY is a new move number, and a new function code is XXX.

Spoiler:

YYY,RISINGVOLTAGE,Rising Voltage,XXX,70,ELECTRIC,Special,100,20,0,00,0,bef,"The user attacks with electric voltage rising from the ground. This move's power doubles when the target is on Electric Terrain."

In Pokebattle_MoveEffects add a new function code XXX

Spoiler:

################################################################################
# Power doubles on Electric Terrain (Rising Voltage)
################################################################################
class PokeBattle_Move_164 < PokeBattle_Move
  
  def pbBaseDamage(basedmg,attacker,opponent)
    return basedmg*2 if @battle.field.effects[PBEffects::ElectricTerrain]>0 
    return basedmg
  end
end

 

[Piratilla98]

Scale Shot
In moves.txt, add this line where YYY is a new move number, and the function code is 0C0.

Spoiler:

YYY,SCALESHOT,Scale Shot,0C0,25,DRAGON,Physical,90,20,0,00,0,bef,"The user attacks by shooting scales two to five times in a row. This move boosts the user's Speed stat but lowers its Defense stat."

In Pokebattle_Battler in def pbProcessMoveAgainstTarget under the berrycurecheck line

Spoiler:

# Berry check (maybe just called by ability effect, since only necessary Berries are checked)
      for j in 0...4
        @battle.battlers[j].pbBerryCureCheck
      end

#Add below here
      if !user.isFainted? && isConst?(thismove.id,PBMoves,:SCALESHOT)
        if user.pbCanReduceStatStage?(PBStats::DEFENSE,user,false,self)
          user.pbReduceStat(PBStats::DEFENSE,1,user,false,self)
        end
        if user.pbCanIncreaseStatStage?(PBStats::SPEED,user,false,self)
          user.pbIncreaseStat(PBStats::SPEED,1,user,false,self)
        end
      end  
##End additions here

      break if user.isFainted? || target.isFainted?
      target.pbUpdateTargetedMove(thismove,user)

Hi, is this coded correctly? The move is supposed to raise the attacker's Speed and lower its Defense 1 time per turn, not after every time it hits

 

[Softshade]

Hi Piratilla, are you sure? This is what Bulbapedia says. "Scale Shot inflicts damage, hitting the target 2-5 times per use. There is a ~33.3% chance that it will hit 2 times, a ~33.3% chance that it will hit 3 times, a ~16.7% chance that it will hit 4 times, and a ~16.7% chance that it will hit 5 times. This means that it will hit about ~3.167 times on average provided that it does not miss, giving it an average power of ~79.2. After each successful hit, the user's Speed is raised by one stage, while its Defense is lowered by one stage. Each strike made has an equal chance to be a critical hit. " I have not seen it in sword gameplay yet, but my reading of Bulbapedia says this is correct

Edit: From here: https://www.youtube.com/watch?v=YaSKNSG5gAw I see you are correct. I will remove the scale shot code for now, will post a fixed version tonight. I have edited Bulbapedia's text to be more clear.

 

[Piratilla98]

Cool. Also, I got this error with your Expanding Force code when I used the move to defeat a mon in a single battle:

 

[Mashirosakura]

Hi Piratilla, are you sure? This is what Bulbapedia says. "Scale Shot inflicts damage, hitting the target 2-5 times per use. There is a ~33.3% chance that it will hit 2 times, a ~33.3% chance that it will hit 3 times, a ~16.7% chance that it will hit 4 times, and a ~16.7% chance that it will hit 5 times. This means that it will hit about ~3.167 times on average provided that it does not miss, giving it an average power of ~79.2. After each successful hit, the user's Speed is raised by one stage, while its Defense is lowered by one stage. Each strike made has an equal chance to be a critical hit. " I have not seen it in sword gameplay yet, but my reading of Bulbapedia says this is correct

Edit: From here: https://www.youtube.com/watch?v=YaSKNSG5gAw I see you are correct. I will remove the scale shot code for now, will post a fixed version tonight. I have edited Bulbapedia's text to be more clear.

https://youtu.be/kZmRYQVJIs8?t=610 This shows the move in action. It does indeed only lower stats after all the hits are made, not every individual hit.

 

[silverlime]

I believe I've finished all the remaining scripting for the new moves (except Misty Explosion because I'm using Reborn Field Effects and I'm too lazy to convert it):

Meteor Beam:

Spoiler:

Add the following code to Pokebattle_MoveEffects:

################################################################################
# Two turn attack. Ups user's Special Attack by 1 stage first turn, attacks second
# turn. (Meteor Beam)
################################################################################
class PokeBattle_Move_1A0 < PokeBattle_Move
  def pbTwoTurnAttack(attacker)
    @immediate=false
    if !@immediate && attacker.hasWorkingItem(:POWERHERB)
      @immediate=true
    end
    return false if @immediate
    return attacker.effects[PBEffects::TwoTurnAttack]==0
  end

  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if @immediate || attacker.effects[PBEffects::TwoTurnAttack]>0
      pbShowAnimation(@id,attacker,opponent,1,alltargets,showanimation) # Charging anim
      @battle.pbDisplay(_INTL("{1} is overflowing with space power!",attacker.pbThis))
      if attacker.pbCanIncreaseStatStage?(PBStats::SPATK,attacker,false,self)
        attacker.pbIncreaseStat(PBStats::SPATK,1,attacker,false,self)
      end
    end
    if @immediate
      @battle.pbCommonAnimation("UseItem",attacker,nil)
      @battle.pbDisplay(_INTL("{1} became fully charged due to its Power Herb!",attacker.pbThis))
      attacker.pbConsumeItem
    end
    return 0 if attacker.effects[PBEffects::TwoTurnAttack]>0
    return super(attacker,opponent,hitnum,alltargets,showanimation)
  end
end

Remember to add this to the moves.txt PBS File (Change 759 to the ID you want for your move):

759,METEORBEAM,Meteor Beam,1A0,120,ROCK,Special,90,10,0,00,0,bef,"In this two-turn attack, the user gathers space power and boosts its Sp. Atk stat, then attacks the target on the next turn."

Corrosive Gas:
THIS IS OUTDATED, SEE REVISED CODE HERE: https://www.pokecommunity.com/showthread.php?p=10181512#post10181512

Spoiler:

In the PBEffects script, add this at the bottom of the "These effects apply to a battler" list (replace 134 with the number 1 greater than the previous effect in the list):

CorrosiveGas       = 134

Find 'def pbInitPermanentEffects' in Pokebattle_Battler and add @effects[PBEffects::CorrosiveGas] = false to the end of the list like so:

  def pbInitPermanentEffects
    # These effects are always retained even if a Pokémon is replaced
    @effects[PBEffects::FutureSight]        = 0
    @effects[PBEffects::FutureSightMove]    = 0
    @effects[PBEffects::FutureSightUser]    = -1
    @effects[PBEffects::FutureSightUserPos] = -1
    @effects[PBEffects::HealingWish]        = false
    @effects[PBEffects::LunarDance]         = false
    @effects[PBEffects::Wish]               = 0
    @effects[PBEffects::WishAmount]         = 0
    @effects[PBEffects::WishMaker]          = -1
    @effects[PBEffects::CorrosiveGas]       = false
  end

Find 'def hasWorkingItem(item,ignorefainted=false)' in Pokebattle_Battler and add the line return false if @effects[PBEffects::CorrosiveGas] like so:

  def hasWorkingItem(item,ignorefainted=false)
    return false if fainted? && !ignorefainted
    return false if @effects[PBEffects::Embargo]>0
    return false if @effects[PBEffects::CorrosiveGas]
    return false if @battle.field.effects[PBEffects::MagicRoom]>0
    return false if self.hasWorkingAbility(:KLUTZ,ignorefainted)
    return isConst?(@item,PBItems,item)
  end

Add the following code to Pokebattle_MoveEffects (I'm not sure what the messages look like when the move fails on a target or how to make the message only apply once when failing for everyone, so I made no message display, though you can tell that the move failed because the other message doesn't play):

################################################################################
# The target's held item is rendered useless for the rest of the battle
# (Corrosive Gas)
################################################################################
class PokeBattle_Move_1A1 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if opponent.effects[PBEffects::CorrosiveGas] || opponent.hasWorkingAbility(:STICKYHOLD) ||
       @battle.pbIsUnlosableItem(opponent,opponent.item) || opponent.item == 0
#      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end
    pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation)
    opponent.effects[PBEffects::CorrosiveGas] = true
    @battle.pbDisplay(_INTL("{1} corroded {2}'s {3}!",attacker.pbThis,opponent.pbThis,
                                                       PBItems.getName(opponent.item)))
    return 0
  end
end

In Pokebattle_MoveEffects, make the following changes to the moves below (changes are in bold):

Spoiler:

################################################################################
# User recovers the last item it held and consumed. (Recycle)
################################################################################
class PokeBattle_Move_0F6 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if !attacker.pokemon || attacker.pokemon.itemRecycle==0[B] || attacker.effects[PBEffects::CorrosiveGas][/B]
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

################################################################################
# User gives its item to the target. The item remains given after wild battles.
# (Bestow)
################################################################################
class PokeBattle_Move_0F3 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if (opponent.effects[PBEffects::Substitute]>0 && !ignoresSubstitute?(attacker)) ||
       attacker.item==0 || opponent.item!=0[B] || opponent.effects[PBEffects::CorrosiveGas][/B]
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

################################################################################
# User and target swap items. They remain swapped after wild battles.
# (Switcheroo, Trick)
################################################################################
class PokeBattle_Move_0F2 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if (opponent.effects[PBEffects::Substitute]>0 && !ignoresSubstitute?(attacker)) ||
       (attacker.item==0 && opponent.item==0) || [B]opponent.effects[PBEffects::CorrosiveGas] && 
       attacker.item > 0 || attacker.effects[PBEffects::CorrosiveGas] && opponent.item > 0 ||[/B]
       ([email protected] && @battle.pbIsOpposing?(attacker.index))
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

################################################################################
# User steals the target's item, if the user has none itself. (Covet, Thief)
# Items stolen from wild Pokémon are kept after the battle.
################################################################################
class PokeBattle_Move_0F1 < PokeBattle_Move
  def pbEffectAfterHit(attacker,opponent,turneffects)
    if !attacker.isFainted? && !opponent.isFainted? && opponent.item!=0 &&
       opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute[B] &&
       !attacker.effects[PBEffects::CorrosiveGas][/B]

In Pokebattle_Battle, find the following code segments and add for Corrosive Gas effect (changes are in bold):

Spoiler:

      # Harvest
      if i.hasWorkingAbility(:HARVEST) && i.item<=0 && i.pokemon.itemRecycle>0[B] && 
         !i.effects[PBEffects::CorrosiveGas][/B]

In Pokebattle_Battler, find the following code segments and add for Corrosive Gas effect (changes are in bold):

Spoiler:

    # Pickpocket
    if target.hasWorkingAbility(:PICKPOCKET)
      if target.item==0 && user.item>0 &&[B] !target.effects[PBEffects::CorrosiveGas] &&[/B]

    # Magician
    if user.hasWorkingAbility(:MAGICIAN)
      if target.item>0 && user.item==0 &&[B] !user.effects[PBEffects::CorrosiveGas] &&[/B]

Make sure you have the fully updated unlosable items list to include gen 7 and gen 8. You can find 'def pbIsUnlosableItem(pkmn,item)' in Pokebattle_Battle and replace the method with the one below or add the parts in bold:

# Checks whether an item can be removed from a Pokémon.
  def pbIsUnlosableItem(pkmn,item)
    return true if pbIsMail?(item)
    [B]return true if pbIsZCrystal?(item)[/B]
    return false if pkmn.effects[PBEffects::Transform]
    return true if pkmn.pokemon && pkmn.pokemon.getMegaForm(true)!=0 # Mega Stone
    if isConst?(pkmn.ability,PBAbilities,:MULTITYPE)
      plates=[:FISTPLATE,:SKYPLATE,:TOXICPLATE,:EARTHPLATE,:STONEPLATE,
              :INSECTPLATE,:SPOOKYPLATE,:IRONPLATE,:FLAMEPLATE,:SPLASHPLATE,
              :MEADOWPLATE,:ZAPPLATE,:MINDPLATE,:ICICLEPLATE,:DRACOPLATE,
              :DREADPLATE,:PIXIEPLATE]
      for i in plates
        return true if isConst?(item,PBItems,i)
      end
    end
[B]    if isConst?(pkmn.ability,PBAbilities,:RKSSYSTEM)
      plates=[:BUGMEMORY,:DARKMEMORY,:DRAGONMEMORY,:ELECTRICMEMORY,:FAIRYMEMORY,
              :FIGHTINGMEMORY,:FIREMEMORY,:FLYINGMEMORY,:GHOSTMEMORY,:GRASSMEMORY,
              :GROUNDMEMORY,:ICEMEMORY,:POISONMEMORY,:PSYCHICMEMORY,:ROCKMEMORY,
              :STEELMEMORY,:WATERMEMORY]
      for i in plates
        return true if isConst?(item,PBItems,i)
      end
    end[/B]
    combos=[[:GIRATINA,:GRISEOUSORB],
            [:GENESECT,:BURNDRIVE],
            [:GENESECT,:CHILLDRIVE],
            [:GENESECT,:DOUSEDRIVE],
            [:GENESECT,:SHOCKDRIVE],
            # Primal Reversion stones
            [:KYOGRE,:BLUEORB],
            [:GROUDON,:REDORB][B],
            [:ZACIAN,:RUSTEDSWORD],
            [:ZAMAZENTA,:RUSTEDSHIELD][/B]
           ]
    for i in combos
      if isConst?(pkmn.species,PBSpecies,i[0]) && isConst?(item,PBItems,i[1])
        return true
      end
    end
    return false
  end

Finally, in the moves.txt PBS file, add the following (Change 762 to the ID that you want for the move):

762,CORROSIVEGAS,Corrosive Gas,1A1,0,POISON,Status,100,40,0,08,0,bce,"The user surrounds everything around it with highly acidic gas and melts away items they hold."

Poltergeist:

Spoiler:

Add the following code to Pokebattle_MoveEffects:

################################################################################
# Fails when the target isn't holding an item (Poltergeist)
################################################################################
class PokeBattle_Move_1A2 < PokeBattle_Move
  def pbMoveFailed(attacker,opponent)
    if opponent.item <= 0 || @battle.field.effects[PBEffects::MagicRoom] > 0 || 
       opponent.hasWorkingAbility(:KLUTZ)
      return true
    else
      @battle.pbDisplay(_INTL("{1} is about to be attacked by its {2}!",opponent.pbThis,PBItems.getName(opponent.item)))
      return false
    end
  end
end

Add the following to moves.txt PBS file:

763,POLTERGEIST,Poltergeist,1A2,110,GHOST,Physical,90,5,0,00,0,bef,"The user attacks the target by controlling the target's item. The move fails if the target doesn't have an item."

EDIT: Added Poltergeist message
Added Corrosive Gas preventing gaining an item

 

[Softshade]

Hi Piratilla, that's what I get for making it work for singles first, then testing, then making it work for doubles, testing, but not retesting for singles.
I've edited the Expanding Force script. The only thing that needs adjusting are the lines from PokeBattle_Battler.
They should now be

Spoiler:

if isConst?(thismove.id,PBMoves,:EXPANDINGFORCE) && @battle.field.effects[PBEffects::PsychicTerrain]>0 && !user.isAirborne? && @battle.doublebattle 
      targets = [pbOpposing1, pbOpposing2] if (!pbOpposing1.isFainted? && !pbOpposing2.isFainted?)
end

 

[Softshade]

Scale Shot (FIXED!)
In PokeBattle_Battler, under the Berry Cure Check

Spoiler:

 for j in 0...4
        @battle.battlers[j].pbBerryCureCheck
      end

#Start here
      if i==numhits-1
        if isConst?(thismove.id,PBMoves,:SCALESHOT) 
          if user.pbCanIncreaseStatStage?(PBStats::SPEED,user,false,self)
            user.pbIncreaseStat(PBStats::SPEED,1,user,false,self)
          end
          if user.pbCanReduceStatStage?(PBStats::DEFENSE,user,false,self)
            user.pbReduceStat(PBStats::DEFENSE,1,user,false,self)
          end
        end
      end

In moves.txt, add this to a new number YYY with function code 0C0 like Water Shuriken

Spoiler:

YYY,SCALESHOT,Scale Shot,0C0,25,DRAGON,Physical,90,20,0,00,0,bef,"The user attacks by shooting scales two to five times in a row. This move boosts the user's Speed stat but lowers its Defense stat."

 

[Softshade]

Silverlime- I believe I've finished all the remaining scripting for the new moves (except Misty Explosion because I'm using Reborn Field Effects and I'm too lazy to convert it):

There seem to be a bunch of moves left if you want to keep working!

Grassy Glide
Terrain Pulse
Skitter Smack
Burning Jealousy
Flip Turn
Triple Axel
Dual Wingbeat
Scorching Sands
Jungle Healing
And of course Misty explosion. I am going to work from top to bottom down this list if anyone else wants to work from bottom up

 

[silverlime]

There seem to be a bunch of moves left if you want to keep working!

Grassy Glide
Terrain Pulse
Skitter Smack
Burning Jealousy
Flip Turn
Triple Axel
Dual Wingbeat
Scorching Sands
Jungle Healing
And of course Misty explosion. I am going to work from top to bottom down this list if anyone else wants to work from bottom up

Ah, yes. Grassy Glide and Terrain Pulse I have coded for Reborn Field Effects but I'll post converted versions shortly. The rest of the moves besides Jungle Healing (which I forgot about) don't need new function codes, so you just need to define them in moves.txt. I'll post everything else shortly. Burning Jealousy was already done I believe.

 

[silverlime]

Here are the rest:

Grassy Glide:

Spoiler:

Add this to Pokebattle_MoveEffects:

################################################################################
# Adds 1 to priority on Grassy Terrain (Grassy Glide)
################################################################################
class PokeBattle_Move_19D < PokeBattle_Move
  # Handeled in priority
end

Go to 'def pbPriority(ignorequickclaw=false,log=false)' in Pokebattle_Battle and paste the following under pri=@choices[2].priority:

pri+=1 if @field.effects[PBEffects::GrassyTerrain]>0 && @choices[i][2].function == 0x19D # Grassy Glide

Find p+=1 if user.hasWorkingAbility(:PRANKSTER) && thismove.pbIsStatus? in Pokebattle_Battler and paste the following underneath:

p+=1 if @battle.field.effects[PBEffects::GrassyTerrain]>0 && thismove.function == 0x19D # Grassy Glide

Terrain Pulse:

Spoiler:

Add this in Pokebattle_MoveEffects:

################################################################################
# Power is doubled in terrain. Type changes depending on the terrain.
# (Terrain Pulse)
################################################################################
class PokeBattle_Move_19E < PokeBattle_Move
  def pbBaseDamage(basedmg,attacker,opponent)
    if @battle.field.effects[PBEffects::ElectricTerrain]>0 || @battle.field.effects[PBEffects::GrassyTerrain]>0 || 
       @battle.field.effects[PBEffects::MistyTerrain]>0 || @battle.field.effects[PBEffects::PsychicTerrain]>0
      return basedmg*2
    end
    return basedmg
  end

  def pbModifyType(type,attacker,opponent)
    if @battle.field.effects[PBEffects::ElectricTerrain]>0
      type = PBTypes::ELECTRIC
    elsif @battle.field.effects[PBEffects::GrassyTerrain]>0
      type = PBTypes::GRASS
    elsif @battle.field.effects[PBEffects::MistyTerrain]>0
      type = PBTYPES::FAIRY
    elsif @battle.field.effects[PBEffects::PsychicTerrain]>0
      type = PBTypes::PSYCHIC
    else
      type = PBTypes::NORMAL
    end
    return type
  end
end

Misty Explosion:

Spoiler:

Add this in Pokebattle_MoveEffects:

################################################################################
# User faints. Power doubles in Misty Terrain (Misty Explosion)
################################################################################
class PokeBattle_Move_0E0 < PokeBattle_Move
  def pbOnStartUse(attacker)
    if !attacker.hasMoldBreaker
      [email protected](:DAMP)
      if bearer!=nil
        @battle.pbDisplay(_INTL("{1}'s {2} prevents {3} from using {4}!",
           bearer.pbThis,PBAbilities.getName(bearer.ability),attacker.pbThis(true),@name))
        return false
      end
    end
    return true
  end

  def pbBaseDamage(basedmg,attacker,opponent)
    if @battle.field.effects[PBEffects::MistyTerrain]>0
      return basedmg*2
    end
    return basedmg
  end
  
  def pbShowAnimation(id,attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    super(id,attacker,opponent,hitnum,alltargets,showanimation)
    if !attacker.fainted?
      attacker.pbReduceHP(attacker.hp)
      attacker.pbFaint if attacker.fainted?
    end
  end
end

Jungle Healing:

Spoiler:

Add the following to Pokebattle_MoveEffects:

###############################################################################
# The user restores 1/4 of its maximum HP, rounded half up. If there is an 
# adjacent ally, the user restores 1/4 of both its and its ally's maximum HP, 
# rounded up. Also heals status conditions. (Jungle Healing)
################################################################################
class PokeBattle_Move_1A5 < PokeBattle_Move
  def isHealingMove?
    return true
  end

  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    didsomething=false
    fullHP=false
    for i in [attacker,attacker.pbPartner]
      next if !i || i.fainted?
      i.status = 0
      if i.hp==i.totalhp
        @battle.pbDisplay(_INTL("{1}'s HP is full!",i.pbThis))
        fullHP=true
        next
      end
      pbShowAnimation(@id,attacker,nil,hitnum,alltargets,showanimation) if !didsomething
      didsomething=true
      showanim=true
      i.pbRecoverHP((i.totalhp/4).round,true)
      @battle.pbDisplay(_INTL("{1}'s HP was restored.",i.pbThis))
    end
    return -1 if fullHP
    if !didsomething
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end
    return 0
  end
end

Remember to add all new moves in the PBS file moves.txt (Change IDs and function codes to be what you need. Bold function codes may need to be changed because they are new functions):

Spoiler:

748,LASHOUT,Lash Out,[B]199[/B],75,DARK,Physical,100,5,0,00,0,bef,"The user lashes out to vent its frustration toward the target. If its stats were lowered during the turn, the power of this move is doubled."
749,FLIPTURN,Flip Turn,0EE,60,WATER,Physical,100,20,0,00,0,abef,"After making its attack, the user rushes back to switch places with a party Pokémon in waiting."
750,BURNINGJEALOUSY,Burning Jealousy,[B]19A[/B],70,FIRE,Special,100,5,100,04,0,bef,"The user attacks with energy from jealousy. This leaves all opposing Pokémon that have had their stats boosted during the turn with a burn."
751,EXPANDINGFORCE,Expanding Force,[B]19B[/B],80,PSYCHIC,Special,100,20,0,00,0,bef,"The user attacks the target with its psychic power. This move's power goes up and damages all opposing Pokémon on Psychic Terrain."
752,RISINGVOLTAGE,Rising Voltage,[B]19C[/B],70,ELECTRIC,Special,100,20,0,00,0,bef,"The user attacks with electric voltage rising from the ground. This move's power doubles when the target is on Electric Terrain."
753,GRASSYGLIDE,Grassy Glide,[B]19D[/B],70,GRASS,Physical,100,20,0,00,0,abef,"Gliding on the ground, the user attacks the target. This move always goes first on Grassy Terrain."
754,SCALESHOT,Scale Shot,0C0,25,DRAGON,Physical,90,20,0,00,0,bef,"The user attacks by shooting scales two to five times in a row. This move boosts the user's Speed stat but lowers its Defense stat."
755,TERRAINPULSE,Terrain Pulse,[B]19E[/B],50,NORMAL,Special,100,10,0,00,0,befm,"The user utilizes the power of the terrain to attack. This move's type and power changes depending on the terrain when it's used."
756,COACHING,Coaching,[B]19F[/B],0,FIGHTING,Status,0,10,0,100,0,c,"The user properly coaches its ally Pokémon, boosting their Attack and Defense stats."
757,SCORCHINGSANDS,Scorching Sands,00A,70,GROUND,Special,100,10,30,00,0,befg,"The user throws scorching sand at the target to attack. This may also leave the target with a burn."
758,DUALWINGBEAT,Dual Wingbeat,0BD,40,FLYING,Physical,10,90,0,00,0,abef,"The user slams the target with its wings. The target is hit twice in a row."
759,METEORBEAM,Meteor Beam,[B]1A0[/B],120,ROCK,Special,90,10,0,00,0,bef,"In this two-turn attack, the user gathers space power and boosts its Sp. Atk stat, then attacks the target on the next turn."
760,SKITTERSMACK,Skitter Smack,045,70,BUG,Physical,90,10,100,00,0,abef,"The user skitters behind the target to attack. This also lowers the target's Sp. Atk stat."
761,TRIPLEAXEL,Triple Axel,0BF,20,ICE,Physical,90,10,0,00,0,abef,"A consecutive three-kick attack that becomes more powerful with each successful hit."
762,CORROSIVEGAS,Corrosive Gas,[B]1A1[/B],0,POISON,Status,100,40,0,08,0,bce,"The user surrounds everything around it with highly acidic gas and melts away items they hold."
763,POLTERGEIST,Poltergeist,[B]1A2[/B],110,GHOST,Physical,90,5,0,00,0,bef,"The user attacks the target by controlling the target's item. The move fails if the target doesn't have an item."
764,STEELROLLER,Steel Roller,[B]1A3[/B],130,STEEL,Physical,100,5,0,00,0,abef,"The user attacks while reverting the terrain. This move fails when there's no temporary terrain."
765,MISTYEXPLOSION,Misty Explosion,[B]1A4[/B],100,FAIRY,Special,100,5,0,08,0,bef,"The user attacks everything around it and faints upon using this move. This move's power is increased on Misty Terrain."
766,JUNGLEHEALING,Jungle Healing,[B]1A5[/B],0,GRASS,Status,0,10,0,40,0,d,"Jungle Healing restores the HP of the user and its allies by 25% of their maximum HP, and heals any non-volatile status conditions they may have."

EDIT: I'm going to assume that Jungle Healing is affected by Snatch because Life Dew is, and they might have just forgotten to add that to Bulbapedia.

 

[Softshade]

I'm not sure if it's a version effect (I'm using 17.1) but for me your Grassy Glide doesn't work since it should be

if @field.effects[PBEffects::GrassyTerrain]>0 && @choices[2].function == 0x19D

instead of

if @battle.field.effects[PBEffects::GrassyTerrain]>0 && @choices[2].function == 0x19D

 

[silverlime]

I'm not sure if it's a version effect (I'm using 17.1) but for me your Grassy Glide doesn't work since it should be

instead of

Yes, you're right, it's not a version thing though. Since that line of code is in the Pokebattle_Battle class, you have to get rid of the @battle part. I was kind of just copying and pasting the terrain-based moves because I was editing them to match original essentials but never tested it with the change. Just fixed it above.

Also, does anyone know the message that Jungle Healing plays when it heals a status condition? I couldn't find this so I just left it with no message for now.

 

[HM100]

I believe I've finished all the remaining scripting for the new moves (except Misty Explosion because I'm using Reborn Field Effects and I'm too lazy to convert it):

Meteor Beam:

Spoiler:

Add the following code to Pokebattle_MoveEffects:

################################################################################
# Two turn attack. Ups user's Special Attack by 1 stage first turn, attacks second
# turn. (Meteor Beam)
################################################################################
class PokeBattle_Move_1A0 < PokeBattle_Move
  def pbTwoTurnAttack(attacker)
    @immediate=false
    if !@immediate && attacker.hasWorkingItem(:POWERHERB)
      @immediate=true
    end
    return false if @immediate
    return attacker.effects[PBEffects::TwoTurnAttack]==0
  end

  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if @immediate || attacker.effects[PBEffects::TwoTurnAttack]>0
      pbShowAnimation(@id,attacker,opponent,1,alltargets,showanimation) # Charging anim
      @battle.pbDisplay(_INTL("{1} is overflowing with space power!",attacker.pbThis))
      if attacker.pbCanIncreaseStatStage?(PBStats::SPATK,attacker,false,self)
        attacker.pbIncreaseStat(PBStats::SPATK,1,attacker,false,self)
      end
    end
    if @immediate
      @battle.pbCommonAnimation("UseItem",attacker,nil)
      @battle.pbDisplay(_INTL("{1} became fully charged due to its Power Herb!",attacker.pbThis))
      attacker.pbConsumeItem
    end
    return 0 if attacker.effects[PBEffects::TwoTurnAttack]>0
    return super(attacker,opponent,hitnum,alltargets,showanimation)
  end
end

Remember to add this to the moves.txt PBS File (Change 759 to the ID you want for your move):

759,METEORBEAM,Meteor Beam,1A0,120,ROCK,Special,90,10,0,00,0,bef,"In this two-turn attack, the user gathers space power and boosts its Sp. Atk stat, then attacks the target on the next turn."

Corrosive Gas:

Spoiler:

In the PBEffects script, add this at the bottom of the "These effects apply to a battler" list (replace 134 with the number 1 greater than the previous effect in the list):

CorrosiveGas       = 134

Find 'def pbInitPermanentEffects' in Pokebattle_Battler and add @effects[PBEffects::CorrosiveGas] = false to the end of the list like so:

  def pbInitPermanentEffects
    # These effects are always retained even if a Pokémon is replaced
    @effects[PBEffects::FutureSight]        = 0
    @effects[PBEffects::FutureSightMove]    = 0
    @effects[PBEffects::FutureSightUser]    = -1
    @effects[PBEffects::FutureSightUserPos] = -1
    @effects[PBEffects::HealingWish]        = false
    @effects[PBEffects::LunarDance]         = false
    @effects[PBEffects::Wish]               = 0
    @effects[PBEffects::WishAmount]         = 0
    @effects[PBEffects::WishMaker]          = -1
    @effects[PBEffects::CorrosiveGas]       = false
  end

Find 'def hasWorkingItem(item,ignorefainted=false)' in Pokebattle_Battler and add the line return false if @effects[PBEffects::CorrosiveGas] like so:

  def hasWorkingItem(item,ignorefainted=false)
    return false if fainted? && !ignorefainted
    return false if @effects[PBEffects::Embargo]>0
    return false if @effects[PBEffects::CorrosiveGas]
    return false if @battle.field.effects[PBEffects::MagicRoom]>0
    return false if self.hasWorkingAbility(:KLUTZ,ignorefainted)
    return isConst?(@item,PBItems,item)
  end

Add the following code to Pokebattle_MoveEffects (I'm not sure what the messages look like when the move fails on a target or how to make the message only apply once when failing for everyone, so I made no message display, though you can tell that the move failed because the other message doesn't play):

################################################################################
# The target's held item is rendered useless for the rest of the battle
# (Corrosive Gas)
################################################################################
class PokeBattle_Move_1A1 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if opponent.effects[PBEffects::CorrosiveGas] || opponent.hasWorkingAbility(:STICKYHOLD) ||
       @battle.pbIsUnlosableItem(opponent,opponent.item) || opponent.item == 0
#      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end
    pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation)
    opponent.effects[PBEffects::CorrosiveGas] = true
    @battle.pbDisplay(_INTL("{1} corroded {2}'s {3}!",attacker.pbThis,opponent.pbThis,
                                                       PBItems.getName(opponent.item)))
    return 0
  end
end

Make sure you have the fully updated unlosable items list to include gen 7 and gen 8. You can find 'def pbIsUnlosableItem(pkmn,item)' in Pokebattle_Battle and replace the method with the one below or add the parts in bold:

# Checks whether an item can be removed from a Pokémon.
  def pbIsUnlosableItem(pkmn,item)
    return true if pbIsMail?(item)
    [B]return true if pbIsZCrystal?(item)[/B]
    return false if pkmn.effects[PBEffects::Transform]
    return true if pkmn.pokemon && pkmn.pokemon.getMegaForm(true)!=0 # Mega Stone
    if isConst?(pkmn.ability,PBAbilities,:MULTITYPE)
      plates=[:FISTPLATE,:SKYPLATE,:TOXICPLATE,:EARTHPLATE,:STONEPLATE,
              :INSECTPLATE,:SPOOKYPLATE,:IRONPLATE,:FLAMEPLATE,:SPLASHPLATE,
              :MEADOWPLATE,:ZAPPLATE,:MINDPLATE,:ICICLEPLATE,:DRACOPLATE,
              :DREADPLATE,:PIXIEPLATE]
      for i in plates
        return true if isConst?(item,PBItems,i)
      end
    end
[B]    if isConst?(pkmn.ability,PBAbilities,:RKSSYSTEM)
      plates=[:BUGMEMORY,:DARKMEMORY,:DRAGONMEMORY,:ELECTRICMEMORY,:FAIRYMEMORY,
              :FIGHTINGMEMORY,:FIREMEMORY,:FLYINGMEMORY,:GHOSTMEMORY,:GRASSMEMORY,
              :GROUNDMEMORY,:ICEMEMORY,:POISONMEMORY,:PSYCHICMEMORY,:ROCKMEMORY,
              :STEELMEMORY,:WATERMEMORY]
      for i in plates
        return true if isConst?(item,PBItems,i)
      end
    end[/B]
    combos=[[:GIRATINA,:GRISEOUSORB],
            [:GENESECT,:BURNDRIVE],
            [:GENESECT,:CHILLDRIVE],
            [:GENESECT,:DOUSEDRIVE],
            [:GENESECT,:SHOCKDRIVE],
            # Primal Reversion stones
            [:KYOGRE,:BLUEORB],
            [:GROUDON,:REDORB][B],
            [:ZACIAN,:RUSTEDSWORD],
            [:ZAMAZENTA,:RUSTEDSHIELD][/B]
           ]
    for i in combos
      if isConst?(pkmn.species,PBSpecies,i[0]) && isConst?(item,PBItems,i[1])
        return true
      end
    end
    return false
  end

Finally, in the moves.txt PBS file, add the following (Change 762 to the ID that you want for the move):

762,CORROSIVEGAS,Corrosive Gas,1A1,0,POISON,Status,100,40,0,08,0,bce,"The user surrounds everything around it with highly acidic gas and melts away items they hold."

Poltergeist:

Spoiler:

Add the following code to Pokebattle_MoveEffects:

################################################################################
# Fails when the target isn't holding an item (Poltergeist)
################################################################################
class PokeBattle_Move_1A2 < PokeBattle_Move
  def pbMoveFailed(attacker,opponent)
    if opponent.item <= 0 || @battle.field.effects[PBEffects::MagicRoom] > 0 || 
       opponent.hasWorkingAbility(:KLUTZ)
      return true
    else
      @battle.pbDisplay(_INTL("{1} is about to be attacked by its {2}!",opponent.pbThis,PBItems.getName(opponent.item)))
      return false
    end
  end
end

Add the following to moves.txt PBS file:

763,POLTERGEIST,Poltergeist,1A2,110,GHOST,Physical,90,5,0,00,0,bef,"The user attacks the target by controlling the target's item. The move fails if the target doesn't have an item."

EDIT: Added Poltergeist message

Corrosive Gas looks great but one point i have:

• Pokémon can't obtain another item while its item is corroded (Trick will fail if either you or the opponent is under Corrosive Gas)

 

[silverlime]

Corrosive Gas looks great but one point i have:

• Pokémon can't obtain another item while its item is corroded (Trick will fail if either you or the opponent is under Corrosive Gas)

Yes, you're right. I'm not sure if a Pokemon can lose or give away a corroded item, but Bulbapedia doesn't mention this so I'm going to assume it's possible. I'll add these conditions in my original post.