Script: Visible Overworld Wild Encounter

[TrankerGolD]

Thank you for noticing that.
For the next update it will be fixed.

About the second error you have, I am not able to replicate it. The script handles if the random tile is valid on the current map, so not sure what will it be.

 

[TrankerGolD]

Hi everyone.
During the implementations of new features I've been wondering about how to handle PokeEvents as temporals, so pokemon are not there after saving and loading up your game.
Since it is a hard task I came up with an Add-On that does something similar but in a forced manner:

Spoiler:

#===============================================================================
# Add-On: Remove all PokeEvent on load_save/transfer by TrankerGolD
#   (only for v19.1)
#===============================================================================
#Method for removing all spawned events
def pbRemovePokeEvents
  if $MapFactory
    for map in $MapFactory.maps
      for event in map.events.values
        if event.name.include? "vanishingEncounter"
          event.removeThisEventfromMap
        end
      end
    end
  end
end
#Overide load_map
module Game
  class << self
    alias original_load_map load_map
  end
  def self.load_map
    original_load_map
    pbRemovePokeEvents
  end
end
#Overide transfer_player (optional)
class Scene_Map
  alias original_transfer_player transfer_player
  def transfer_player(cancelVehicles=true)
    pbRemovePokeEvents
    original_transfer_player(cancelVehicles)
  end
end

This Add-On is a simple idea that removes all PokeEvents when loading a save and when transferring.
Concerning player transferring:
- Sometimes a transfer to the same map can happen, which won't clear and update the map
- If you want to use it on specific transfers you will have to delete the last part ("#Overide transfer_player"...) and call "pbRemovePokeEvents" right before transferring to another location of the same map.

Also, with this Add-On you can call the script "pbRemovePokeEvents" inside any event whenever needed.

 

[TrankerGolD]

In this post I bring not Add-On, but an animation resource.

So, for everyone who haven't noticed yet the new script for PEv19.1 has parameters to store the id of specific animations.
Currently, since the only thing provided is code there was no need for this kind of thing.
But for anyone that is interested in this, here are some examples on what you can do with them:

Spoiler:

(When shiny or agressive the animations have a specific sound effect so you can notice without looking)

You can find these new animations I created in this download.

(WARNING! This resource overrides your current animations.rxdata which contains all animations from the database, DON'T use this resource if you already edited yours.)

If you already have your own animations and still want to try these ones here is a little tip:

Spoiler:

- First, copy your project folder (or download PEv19.1) 
- Second, paste there (in the copy) the animations.rxdata in Data folder
- Third, open both your project and the copied project with the animations
- Fourth, in the copied project open database, go to Animations, click "008: Shiny", and do Ctrl+C
- Fifth, in your own proyect do the same but click a blank space with no animations and do Ctrl+V
- Sixth, do the 4th and 5th step with:
	- "009: Shiny no sound"
	- "010: Water splash"
	- "011: Agressive"
- Seventh, make sure your project has the audio and graphic
- Eighth, change in VisibleEncounterSettings the id for the animations

You can totally make your own animations instead, and remember this is for the script that works with PEv19.1 version.

 

[gtx00900]

Hi everyone.
During the implementations of new features I've been wondering about how to handle PokeEvents as temporals, so pokemon are not there after saving and loading up your game.
Since it is a hard task I came up with an Add-On that does something similar but in a forced manner:

Spoiler:

#===============================================================================
# Add-On: Remove all PokeEvent on load_save/transfer by TrankerGolD
#   (only for v19.1)
#===============================================================================
#Method for removing all spawned events
def pbRemovePokeEvents
  if $MapFactory
    for map in $MapFactory.maps
      for event in map.events.values
        if event.name.include? "vanishingEncounter"
          event.removeThisEventfromMap
        end
      end
    end
  end
end
#Overide load_map
module Game
  class << self
    alias original_load_map load_map
  end
  def self.load_map
    original_load_map
    pbRemovePokeEvents
  end
end
#Overide transfer_player (optional)
class Scene_Map
  alias original_transfer_player transfer_player
  def transfer_player(cancelVehicles=true)
    pbRemovePokeEvents
    original_transfer_player(cancelVehicles)
  end
end

This Add-On is a simple idea that removes all PokeEvents when loading a save and when transferring.
Concerning player transferring:
- Sometimes a transfer to the same map can happen, which won't clear and update the map
- If you want to use it on specific transfers you will have to delete the last part ("#Overide transfer_player"...) and call "pbRemovePokeEvents" right before transferring to another location of the same map.

Also, with this Add-On you can call the script "pbRemovePokeEvents" inside any event whenever needed.

Got this error when trying to load a saved game with wild pokemon on map, after installing the addon:

Spoiler:

[Pokémon Essentials version 19.1]
[v19.1 Hotfixes 1.0.5]

Exception: NoMethodError
Message: undefined method `spritesets' for #<Scene_DebugIntro>

Backtrace:
342:Overworld_VisibleEncounters:1230:in `removeThisEventfromMap'
342:Overworld_VisibleEncounters:1408:in `block (2 levels) in pbRemovePokeEvents'
342:Overworld_VisibleEncounters:1406:in `each'
342:Overworld_VisibleEncounters:1406:in `block in pbRemovePokeEvents'
342:Overworld_VisibleEncounters:1405:in `each'
342:Overworld_VisibleEncounters:1405:in `pbRemovePokeEvents'
342:Overworld_VisibleEncounters:1421:in `load_map'
031:StartGame:64:in `load'
280:UI_Load:309:in `block in pbStartLoadScreen'
280:UI_Load:303:in `loop'

 

[TrankerGolD]

Got this error when trying to load a saved game with wild pokemon on map, after installing the addon:

Spoiler:

[Pokémon Essentials version 19.1]
[v19.1 Hotfixes 1.0.5]

Exception: NoMethodError
Message: undefined method `spritesets' for #<Scene_DebugIntro>

Backtrace:
342:Overworld_VisibleEncounters:1230:in `removeThisEventfromMap'
342:Overworld_VisibleEncounters:1408:in `block (2 levels) in pbRemovePokeEvents'
342:Overworld_VisibleEncounters:1406:in `each'
342:Overworld_VisibleEncounters:1406:in `block in pbRemovePokeEvents'
342:Overworld_VisibleEncounters:1405:in `each'
342:Overworld_VisibleEncounters:1405:in `pbRemovePokeEvents'
342:Overworld_VisibleEncounters:1421:in `load_map'
031:StartGame:64:in `load'
280:UI_Load:309:in `block in pbStartLoadScreen'
280:UI_Load:303:in `loop'

Make sure you got the base script code right, install it again and add the Add-On

 

[gtx00900]

Make sure you got the base script code right, install it again and add the Add-On

Indeed, updating the script did the trick but I didn't do that before because I was already using v.19.0.10 - so I assumed no changes were made. Seems like you forgot to change the version.

 

[zacmanattack13]

Has the modification for "different encounters for over-world spawning and original encountering on the same map - like in Pokemon Sword/Shield" been updated for V19.1?

 

[TrankerGolD]

Has the modification for "different encounters for over-world spawning and original encountering on the same map - like in Pokemon Sword/Shield" been updated for V19.1?

It wasn't updated.

Here is the instruction to different encounters for over-world spawning and original encountering on the same map in V19.1:

Insert a new line in scripts under "Overworld_VisibleEncounter" and call it "Overworld_EncounterType", and paste this code inside:

Spoiler:

#===============================================================================
# * Different EncounterType
# *   for over-world spawning and original encountering on the same map
# * by TrankerGolD
# * made for Visible Overworld Wild Encounters for PEv19.1 - by derFischae and TrankerGolD (Credits if used please) *
#===============================================================================
GameData::EncounterType.register({
  :id             => :OverworldLand,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandDay,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandNight,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandMorning,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandAfternoon,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandEvening,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCave,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveDay,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveNight,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveMorning,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveAfternoon,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveEvening,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWater,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterDay,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterNight,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterMorning,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterAfternoon,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterEvening,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldBugContest,
  :type           => :overworld_contest,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

#===============================================================================
# adding new Methods encounter_type_on_tile and encounter_possible_here_on_tile?
# in Class PokemonEncounters
#===============================================================================

class PokemonEncounters
  
  #=============================================================================
  
  # Returns whether land-like encounters have been defined for the current map.
  # Applies only to encounters triggered by moving around.
  def has_overworld_land_encounters?
    GameData::EncounterType.each do |enc_type|
      next if ![:overworld_land, :overworld_contest].include?(enc_type.type)
      return true if has_encounter_type?(enc_type.id)
    end
    return false
  end

  # Returns whether land-like encounters have been defined for the current map
  # (ignoring the Bug Catching Contest one).
  # Applies only to encounters triggered by moving around.
  def has_normal_overworld_land_encounters?
    GameData::EncounterType.each do |enc_type|
      return true if enc_type.type == :overworld_land && has_encounter_type?(enc_type.id)
    end
    return false
  end

  # Returns whether cave-like encounters have been defined for the current map.
  # Applies only to encounters triggered by moving around.
  def has_overworld_cave_encounters?
    GameData::EncounterType.each do |enc_type|
      return true if enc_type.type == :overworld_cave && has_encounter_type?(enc_type.id)
    end
    return false
  end

  # Returns whether water-like encounters have been defined for the current map.
  # Applies only to encounters triggered by moving around (i.e. not fishing).
  def has_overworld_water_encounters?
    GameData::EncounterType.each do |enc_type|
      return true if enc_type.type == :overworld_water && has_encounter_type?(enc_type.id)
    end
    return false
  end
  
  #=============================================================================
  
  def encounter_type_on_tile(x,y)
    time = pbGetTimeNow
    ret = nil
    if has_overworld_water_encounters? && $game_map.terrain_tag(x,y).can_surf_freely
      ret = find_valid_encounter_type_for_time(:OverworldWater, time)
    else   # OverworldLand/OverworldCave (can have both in the same map)
      if has_overworld_land_encounters? && $game_map.terrain_tag(x, y).land_wild_encounters
        ret = :OverworldBugContest if pbInBugContest? && has_encounter_type?(:OverworldBugContest)
        ret = find_valid_encounter_type_for_time(:OverworldLand, time) if !ret
      end
      if !ret && has_overworld_cave_encounters?
        ret = find_valid_encounter_type_for_time(:OverworldCave, time)
      end
    end
    return ret
  end
  
end

And done, the solution is much simpler in PEv19.1 (no need to modify scripts)

How to use:

Spoiler:

- Go to encounters.txt in the PBS folder.
- Use for example OverworldLand instead of Land for visible encounters spawning.
- All new EncounterType are:
	OverworldLand
	OverworldLandDay
	OverworldLandNight
	OverworldLandMorning
	OverworldLandAfternoon
	OverworldLandEvening
	OverworldCave
	OverworldCaveDay
	OverworldCaveNight
	OverworldCaveMorning
	OverworldCaveAfternoon
	OverworldCaveEvening
	OverworldWater
	OverworldWaterDay
	OverworldWaterNight
	OverworldWaterMorning
	OverworldWaterAfternoon
	OverworldWaterEvening
	OverworldBugContest
- (NOTE: using this script will restrict visible encounters spawn to the new EncounterTypes)

I think this should work properly as intended.

 

[zacmanattack13]

It wasn't updated.

Here is the instruction to different encounters for over-world spawning and original encountering on the same map in V19.1:

Insert a new line in scripts under "Overworld_VisibleEncounter" and call it "Overworld_EncounterType", and paste this code inside:

Spoiler:

#===============================================================================
# * Different EncounterType
# *   for over-world spawning and original encountering on the same map
# * by TrankerGolD
# * made for Visible Overworld Wild Encounters for PEv19.1 - by derFischae and TrankerGolD (Credits if used please) *
#===============================================================================
GameData::EncounterType.register({
  :id             => :OverworldLand,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandDay,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandNight,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandMorning,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandAfternoon,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandEvening,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCave,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveDay,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveNight,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveMorning,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveAfternoon,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveEvening,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWater,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterDay,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterNight,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterMorning,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterAfternoon,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterEvening,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldBugContest,
  :type           => :overworld_contest,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

#===============================================================================
# adding new Methods encounter_type_on_tile and encounter_possible_here_on_tile?
# in Class PokemonEncounters
#===============================================================================

class PokemonEncounters
  
  def encounter_type_on_tile(x,y)
    time = pbGetTimeNow
    ret = nil
    if $game_map.terrain_tag(x,y).can_surf_freely
      ret = find_valid_encounter_type_for_time(:OverworldWater, time)
    else   # OverworldLand/OverworldCave (can have both in the same map)
      if has_land_encounters? && $game_map.terrain_tag(x, y).land_wild_encounters
        ret = :OverworldBugContest if pbInBugContest? && has_encounter_type?(:OverworldBugContest)
        ret = find_valid_encounter_type_for_time(:OverworldLand, time) if !ret
      end
      if !ret && has_cave_encounters?
        ret = find_valid_encounter_type_for_time(:OverworldCave, time)
      end
    end
    return ret
  end
  
end

And done, the solution is much simpler in PEv19.1 (no need to modify scripts)

How to use:

Spoiler:

- Go to encounters.txt in the PBS folder.
- Use for example OverworldLand instead of Land for visible encounters spawning.
- All new EncounterType are:
	OverworldLand
	OverworldLandDay
	OverworldLandNight
	OverworldLandMorning
	OverworldLandAfternoon
	OverworldLandEvening
	OverworldCave
	OverworldCaveDay
	OverworldCaveNight
	OverworldCaveMorning
	OverworldCaveAfternoon
	OverworldCaveEvening
	OverworldWater
	OverworldWaterDay
	OverworldWaterNight
	OverworldWaterMorning
	OverworldWaterAfternoon
	OverworldWaterEvening
	OverworldBugContest
- (NOTE: using this script will restrict visible encounters spawn to the new EncounterTypes)

I think this should work properly as intended.

Thank you! Works as intended so far!

 

[PFA The Pokemon Fan]

I always get syntax errors when i put that script in

 

[TrankerGolD]

I always get syntax errors when i put that script in

You will need to specify and provide more information. What is your error log? Are you referring to the main script or the different encounters script? What version are you using?

 

[PFA The Pokemon Fan]

can somebody do the plug in version of it, not the script because the script gives me alot of errors and plug ins are easy

 

[PFA The Pokemon Fan]

I'm using V19.1

 

[DarrylBD99]

It wasn't updated.

Here is the instruction to different encounters for over-world spawning and original encountering on the same map in V19.1:

Insert a new line in scripts under "Overworld_VisibleEncounter" and call it "Overworld_EncounterType", and paste this code inside:

Spoiler:

#===============================================================================
# * Different EncounterType
# *   for over-world spawning and original encountering on the same map
# * by TrankerGolD
# * made for Visible Overworld Wild Encounters for PEv19.1 - by derFischae and TrankerGolD (Credits if used please) *
#===============================================================================
GameData::EncounterType.register({
  :id             => :OverworldLand,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandDay,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandNight,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandMorning,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandAfternoon,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldLandEvening,
  :type           => :overworld_land,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCave,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveDay,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveNight,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveMorning,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveAfternoon,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldCaveEvening,
  :type           => :overworld_cave,
  :trigger_chance => 5,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWater,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterDay,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterNight,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterMorning,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterAfternoon,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldWaterEvening,
  :type           => :overworld_water,
  :trigger_chance => 2,
  :old_slots      => [60, 30, 5, 4, 1]
})

GameData::EncounterType.register({
  :id             => :OverworldBugContest,
  :type           => :overworld_contest,
  :trigger_chance => 21,
  :old_slots      => [20, 20, 10, 10, 10, 10, 5, 5, 4, 4, 1, 1]
})

#===============================================================================
# adding new Methods encounter_type_on_tile and encounter_possible_here_on_tile?
# in Class PokemonEncounters
#===============================================================================

class PokemonEncounters
  
  def encounter_type_on_tile(x,y)
    time = pbGetTimeNow
    ret = nil
    if $game_map.terrain_tag(x,y).can_surf_freely
      ret = find_valid_encounter_type_for_time(:OverworldWater, time)
    else   # OverworldLand/OverworldCave (can have both in the same map)
      if has_land_encounters? && $game_map.terrain_tag(x, y).land_wild_encounters
        ret = :OverworldBugContest if pbInBugContest? && has_encounter_type?(:OverworldBugContest)
        ret = find_valid_encounter_type_for_time(:OverworldLand, time) if !ret
      end
      if !ret && has_cave_encounters?
        ret = find_valid_encounter_type_for_time(:OverworldCave, time)
      end
    end
    return ret
  end
  
end

And done, the solution is much simpler in PEv19.1 (no need to modify scripts)

How to use:

Spoiler:

- Go to encounters.txt in the PBS folder.
- Use for example OverworldLand instead of Land for visible encounters spawning.
- All new EncounterType are:
	OverworldLand
	OverworldLandDay
	OverworldLandNight
	OverworldLandMorning
	OverworldLandAfternoon
	OverworldLandEvening
	OverworldCave
	OverworldCaveDay
	OverworldCaveNight
	OverworldCaveMorning
	OverworldCaveAfternoon
	OverworldCaveEvening
	OverworldWater
	OverworldWaterDay
	OverworldWaterNight
	OverworldWaterMorning
	OverworldWaterAfternoon
	OverworldWaterEvening
	OverworldBugContest
- (NOTE: using this script will restrict visible encounters spawn to the new EncounterTypes)

I think this should work properly as intended.

I don't know if I am missing a step but all the "overworld_[encounterType]" types aren't defined in those "has_[encounterType]_encounters?" functions.

 

[TrankerGolD]

I don't know if I am missing a step but all the "overworld_[encounterType]" types aren't defined in those "has_[encounterType]_encounters?" functions.

You are right, i edited the code in that post ( this will fix the issue where "OverworldLand" only worked when "Land" is also defined )

 

[Legend AshGreninja]

brilliant Pokemon appear in overworld with gold Waves animation how can I do this? Iam using generation 8 project in Pokemon essentials v19.1

 

[TrankerGolD]

brilliant Pokemon appear in overworld with gold Waves animation how can I do this? Iam using generation 8 project in Pokemon essentials v19.1

About brilliant pokemon gold waves animation, the only way for now to add is editing the main code. The idea would be replicating everything related to shininess (except the appear animation, since you only want the looped one, I suppose, that will be in the PokeEvent update), not only that but also adding a new parameter for brilliant value on every method.

For example, inside pbSpawnOnStepTaken this part should look like this:

Spoiler:

...
isShiny = pokemon.shiny
isBrilliant = nil
isBrilliant = pokemon.brilliant if defined?(pokemon.brilliant)
pbPlaceEncounter(pos[0],pos[1],encounter,gender,form,isShiny,isBrilliant)
...

The defined? conditional is only there to prevent games without gen 8 project from breaking

But more code would need to be edited.

 

[REALMUGEN]

Hi everyone. Again congratulations and thanks for such an incredible script.

I am working on a project in version 17.2 and I am trying to edit a piece of the catchcombo Add On so that I can use it when a Pokemon is captured and not when it is weakened (in regular encounters).

The problem is that I do not know scripting so well as to edit it and make sure that the chain of captures does not break when finding a different Pokemon,
if not memorized until the complete chain of a certain species is captured (or broken only when a different one is captured).

Example:

Caught Ekans + Caught Ekans + Kill Spearow + Run away from Pikachu + Caught Ekans + Caught Ekans ==== Still works
Caught Ekans + Caught Ekans + Caught Spearow ==== The chain breaks

(sorry for the example my english is not the best and i want to make sure i am explaining myself well)

Any ideas on how to do this? Thanks again...

PD: This is the code (basically the original)

Spoiler:

CHAINLENGTH = 2          
#===============================================================================
# adding a new instance variable to $PokemonTemp in script PField_Metadata to
# remember which pokemon and how many of that kind were killed in a row
#===============================================================================
class PokemonTemp
  attr_accessor :catchcombo # [chain length, species]
end

#===============================================================================
# adding a new event handler on Battle end to update the catchchain (where the
# pokemon-kill-chain is saved)
#===============================================================================
Events.onWildBattleEnd+=proc {|sender,e|
  species=e[0]
  result=e[2]
  $PokemonTemp.catchcombo = [0,0] if !$PokemonTemp.catchcombo
  if $PokemonTemp.catchcombo[1]!=species
    $PokemonTemp.catchcombo=[0,species]
  end
  if result==4 && species==$PokemonTemp.catchcombo[1]
    $PokemonTemp.catchcombo[0]+=1
    Kernel.pbMessage(_INTL("You Caught {1} {2}",$PokemonTemp.catchcombo[0],$PokemonTemp.catchcombo[1]))
  end
}

Events.onStartBattle+=proc {|sender,e|
    pokemon=e[0]
    next if pokemon.nil?
    $PokemonTemp.catchcombo=[0,0] if !$PokemonTemp.catchcombo
    if ($PokemonTemp.catchcombo[0]>=CHAINLENGTH && $PokemonTemp.catchcombo[1]==pokemon.species)
      if rand(SHINYPROBABILITY)<$PokemonTemp.catchcombo[0]
        pokemon.makeShiny
      end
    end
}

 

[TrankerGolD]

Hi everyone. Again congratulations and thanks for such...

If i remember correctly result == 4 is when you catched the pokemon (1 for example when battle won), also the reset should be inside the result condition.

Spoiler:

CHAINLENGTH = 2          
#===============================================================================
# adding a new instance variable to $PokemonTemp in script PField_Metadata to
# remember which pokemon and how many of that kind were killed in a row
#===============================================================================
class PokemonTemp
  attr_accessor :catchcombo # [chain length, species]
end

#===============================================================================
# adding a new event handler on Battle end to update the catchchain (where the
# pokemon-kill-chain is saved)
#===============================================================================
Events.onWildBattleEnd+=proc {|sender,e|
  species=e[0]
  result=e[2]
  $PokemonTemp.catchcombo = [0,0] if !$PokemonTemp.catchcombo
  if result==4
    $PokemonTemp.catchcombo=[0,species] if species!=$PokemonTemp.catchcombo[1]
    $PokemonTemp.catchcombo[0]+=1
    Kernel.pbMessage(_INTL("You Caught {1} {2}",$PokemonTemp.catchcombo[0],$PokemonTemp.catchcombo[1]))
  end
}

Events.onStartBattle+=proc {|sender,e|
    pokemon=e[0]
    next if pokemon.nil?
    $PokemonTemp.catchcombo=[0,0] if !$PokemonTemp.catchcombo
    if ($PokemonTemp.catchcombo[0]>=CHAINLENGTH && $PokemonTemp.catchcombo[1]==pokemon.species)
      if rand(SHINYPROBABILITY)<$PokemonTemp.catchcombo[0]
        pokemon.makeShiny
      end
    end
}

 

[REALMUGEN]

If i remember correctly result == 4 is when you catched the pokemon (1 for example when battle won), also the reset should be inside the result condition.

Spoiler:

CHAINLENGTH = 2          
#===============================================================================
# adding a new instance variable to $PokemonTemp in script PField_Metadata to
# remember which pokemon and how many of that kind were killed in a row
#===============================================================================
class PokemonTemp
  attr_accessor :catchcombo # [chain length, species]
end

#===============================================================================
# adding a new event handler on Battle end to update the catchchain (where the
# pokemon-kill-chain is saved)
#===============================================================================
Events.onWildBattleEnd+=proc {|sender,e|
  species=e[0]
  result=e[2]
  $PokemonTemp.catchcombo = [0,0] if !$PokemonTemp.catchcombo
  if result==4
    $PokemonTemp.catchcombo=[0,species] if species!=$PokemonTemp.catchcombo[1]
    $PokemonTemp.catchcombo[0]+=1
    Kernel.pbMessage(_INTL("You Caught {1} {2}",$PokemonTemp.catchcombo[0],$PokemonTemp.catchcombo[1]))
  end
}

Events.onStartBattle+=proc {|sender,e|
    pokemon=e[0]
    next if pokemon.nil?
    $PokemonTemp.catchcombo=[0,0] if !$PokemonTemp.catchcombo
    if ($PokemonTemp.catchcombo[0]>=CHAINLENGTH && $PokemonTemp.catchcombo[1]==pokemon.species)
      if rand(SHINYPROBABILITY)<$PokemonTemp.catchcombo[0]
        pokemon.makeShiny
      end
    end
}

Oh! Thank you so much.
Until now it works good. Thanks for the help.

I was not managing to find the correct code, my brain was boiling.